Arb instances #3
Conversation
|
Review by @paf31 |
|
Cool, thanks. I had to think a bit about what we want our best practices to be about arb instances, but I think this is good - core instances in Test.QuickCheck, other things can depend on quickcheck. It seems a little bit of a shame for lists to have a dependency on quickcheck, but it's not the end of the world. |
|
I agree. I think ultimately every library that exports data types should have a dependency on quickcheck. The alternative orphan-less solution is for quickcheck to have a dependency on every library in the world, which is probably the greater of two evils. :) |
|
Btw I am not tagging these commits, which is how I gather bower decides what the version should be. I assume merger should tag the commits, or should the submitter of the PR tag them with what they think should be the correct version number? |
|
I need to make a release, which I'll do now. Then bower will pick up the new version. |
No description provided.