Skip to content

Add ListT #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2014
Merged

Add ListT #2

merged 4 commits into from
Sep 30, 2014

Conversation

jdegoes
Copy link
Contributor

@jdegoes jdegoes commented Sep 30, 2014

Review by @paf31, @joneshf.

I believe this PR also demonstrates (3) compiler bugs, which I have documented in comments and will create issues for in the compiler project.

@paf31
Copy link
Contributor

paf31 commented Sep 30, 2014

Looks nice.

Is LazyF meant to be there still?

@jdegoes
Copy link
Contributor Author

jdegoes commented Sep 30, 2014

I deleted the dead code and hid the constructor for Step. Should be good to go, /cc @paf31.

@paf31
Copy link
Contributor

paf31 commented Sep 30, 2014

One more question, for my understanding: what is Skip for?

@jdegoes
Copy link
Contributor Author

jdegoes commented Sep 30, 2014

Skip allows you to execute effects any place without yielding values. It also allows you to implement many operations with a Functor instead of a full monad (see stepMap and all the places it's used).

@paf31
Copy link
Contributor

paf31 commented Sep 30, 2014

Cool, makes sense.

paf31 added a commit that referenced this pull request Sep 30, 2014
@paf31
Merge pull request #2 from jdegoes/listt
6dc5381 
Add ListT
@paf31 paf31 merged commit 6dc5381 into purescript:master Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdegoes @paf31