Topic/create element #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createElement function takes a component factory and props and creates a new component that can be nested in other components.
|
Can the factory get access to the |
|
Good point. I think adding something like: foreign import getChildren :: forall props eff. UIRef -> Eff (props :: ReactProps props | eff) (Array UI)Would allow the component to get the passed-in children. I can add this to this PR. |
Allows for access to the implicit `children` prop on components.
|
I'm not very familiar with this function, but if you're able to verify it works on an example, I'm happy to merge it. |
|
Great! I will add an example. And |
|
Just wanted to send a ping on this. Does the above example for |
|
👍 Sorry for the delay. |
|
No problem. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
createElementthat takes a component factory along with a set of props and creates a UI element. I am open for discussion on this one. However, the main use-case is to allow the developer to render their React components from within other React components.