Force update #103
Merged
Force update #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2017 23:05
paf31
reviewed
Jul 13, 2017
src/React.purs
Outdated
| @@ -335,6 +340,25 @@ createClassStateless' k = | |||
| createClassStateless \props -> | |||
| k props (childrenToArray (unsafeCoerce props).children) | |||
|
|
|||
| foreign import forceUpdateImpl :: forall eff props state. | |||
There was a problem hiding this comment.
Can this one can be implemented in terms of the other using pure unit?
paf31
reviewed
Jul 13, 2017
src/React.js
Outdated
| @@ -122,6 +122,20 @@ function createClass(spec) { | |||
| } | |||
| exports.createClass = createClass; | |||
|
|
|||
| function forceUpdateImpl(this_) { | |||
There was a problem hiding this comment.
This is no longer used, right?
There was a problem hiding this comment.
I just forgot to push all changes.
|
Looks good to me. @paf31 Good for me to do the merge? |
|
👍 If you're happy, go ahead please. Sorry I haven't had time to review PRs as much lately. |
|
No problem. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forceUpdate. This PR includes two versions: with and without the callback argument: