Broken satisfy

[nkly]

Hello! While writing query string parser for my pet project I noticed that some simple parsers aren't working. I've digged a little and found that failing in satisfy actually consumes failed character and thus fails every other parser combinator that depends on satisfy. I've attached simple test and quite straightforward fix for this problem.

[paf31]

I do agree that satisfy should not consume input if the predicate fails. However, I'd really like to not have to define this in terms of the underlying monad, but reuse things like char. I feel like we could fix this by just adding a try. Does that not work?

[nkly]

Yes, it's much better and clearer this way

[paf31]

Does this work as you'd like? If so, I'll merge it.

@jdegoes You wrote this originally I think. Do you see any reason not to wrap this with try?

[jdegoes]

No, I'd prefer it with try. The new solution looks good to merge. @paf31?

[paf31]

Thanks 👍

[garyb]

Nice 👍