Skip to content

Commit ea7e558

Browse files
authored
Fix warnings revealed by PureScript v0.14.1 (#36)
* Fix dependency warnings * Fix UnusedName warnings on v0.14.1 * Update CHANGELOG.md
1 parent d211820 commit ea7e558

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ New features:
1111
Bugfixes:
1212

1313
Other improvements:
14+
- Removed unused names found by the v0.14.1 PureScript release (#36)
15+
- Installed dependencies directly imported into source code that were previously installed transitively and removed unused `record` dependency (#36)
1416

1517
## [v7.0.0](https://github.com/purescript-contrib/purescript-argonaut-generic/releases/tag/v7.0.0) - 2021-02-26
1618

spago.dhall

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,19 @@
22
, dependencies =
33
[ "argonaut-codecs"
44
, "argonaut-core"
5+
, "arrays"
56
, "assert"
7+
, "bifunctors"
68
, "console"
9+
, "control"
710
, "effect"
11+
, "either"
812
, "exceptions"
13+
, "foreign-object"
14+
, "partial"
915
, "prelude"
1016
, "psci-support"
11-
, "record"
17+
, "strings"
1218
]
1319
, packages = ./packages.dhall
1420
, sources = [ "src/**/*.purs", "test/**/*.purs" ]

src/Data/Argonaut/Decode/Generic.purs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ decodeRep :: forall r. DecodeRep r => Json -> Either JsonDecodeError r
3535
decodeRep = decodeRepWith defaultEncoding
3636

3737
instance decodeRepNoConstructors :: DecodeRep Rep.NoConstructors where
38-
decodeRepWith e _ = Left $ UnexpectedValue $ fromString "NoConstructors (Cannot decode empty data type)"
38+
decodeRepWith _ _ = Left $ UnexpectedValue $ fromString "NoConstructors (Cannot decode empty data type)"
3939

4040
instance decodeRepSum :: (DecodeRep a, DecodeRep b) => DecodeRep (Rep.Sum a b) where
4141
decodeRepWith e j = Rep.Inl <$> decodeRepWith e j <|> Rep.Inr <$> decodeRepWith e j
@@ -88,13 +88,13 @@ construct e valuesArray decodingErr = do
8888
instance decodeRepConstructorNoArgs :: IsSymbol name => DecodeRep (Rep.Constructor name Rep.NoArguments) where
8989
decodeRepWith e j = do
9090
let name = reflectSymbol (Proxy :: Proxy name)
91-
{tag, decodingErr} <- withTag e j name
91+
{decodingErr} <- withTag e j name
9292
construct e [] decodingErr
9393
else
9494
instance decodeRepConstructorArg :: (IsSymbol name, DecodeJson a) => DecodeRep (Rep.Constructor name (Rep.Argument a)) where
9595
decodeRepWith e j = do
9696
let name = reflectSymbol (Proxy :: Proxy name)
97-
{tag, values, decodingErr} <- withTagAndValues e j name
97+
{values, decodingErr} <- withTagAndValues e j name
9898
if e.unwrapSingleArguments
9999
then construct e [values] decodingErr
100100
else do
@@ -104,7 +104,7 @@ else
104104
instance decodeRepConstructor :: (IsSymbol name, DecodeRepArgs a) => DecodeRep (Rep.Constructor name a) where
105105
decodeRepWith e j = do
106106
let name = reflectSymbol (Proxy :: Proxy name)
107-
{tag, values, decodingErr} <- withTagAndValues e j name
107+
{values, decodingErr} <- withTagAndValues e j name
108108
valuesArray <- note (decodingErr $ AtKey e.valuesKey $ TypeMismatch "Array") (toArray values)
109109
construct e valuesArray decodingErr
110110

0 commit comments

Comments
 (0)