Skip to content

(maint) - Add HTML anchor tag #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 7, 2018

Conversation

clairecadman
Copy link
Contributor

This commit adds HTML anchor tags to improving the localization.

@clairecadman
Copy link
Contributor Author

clairecadman commented Dec 3, 2018

@jemalizee Does this look okay? I just want to check this is correct before I do more. Thanks!

@pmcmaw pmcmaw changed the title Add HTML anchor tag (maint) - Add HTML anchor tag Dec 4, 2018
@clairecadman clairecadman requested a review from pmcmaw December 5, 2018 15:01
Copy link
Contributor

@pmcmaw pmcmaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Also thanks for the few docs updates :-)
Would it be possible to elaborate on these changes so we know how it improves localization? As this is going to happen with more modules, a bit of background would be cool :-)

@clairecadman
Copy link
Contributor Author

@pmcmaw Thank you! The anchor tag will help you fix broken links — If the header text changes (gets localized) the link will brake. I'll make sure to elaborate on future localization changes :)

@clairecadman clairecadman merged commit 19cdf29 into puppetlabs:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants