(MODULES-4908) adds support for sensitive data type to pw_hash #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eputnam
force-pushed
the
MODULES-4908
branch
3 times, most recently
from
cf9e44e to
89dd42c
Compare
|
blocked by Appveyor running tests with Puppet 4.2.3 |
eputnam
force-pushed
the
MODULES-4908
branch
3 times, most recently
from
f8126eb to
e02359c
Compare
|
no longer blocked and ready for merge |
Also includes a small fix to integer_spec so tests pass.
hunner
added a commit
that referenced
this pull request
Jul 20, 2017
(MODULES-4908) adds support for sensitive data type to pw_hash
|
This seems to have broken our tests runs under 4.5.3 http://logs.openstack.org/34/489534/5/check/gate-puppet-pacemaker-puppet-unit-4.5-centos-7/3ee7b4d/console.html#_2017-08-02_05_57_10_708889 |
|
@mwhahaha makes sense, the Sensitive type wasn't introduced until Puppet 4.6.x |
|
Yea is problematic because we still run 4.5 for tests. We're pinning to 4.16.0 as a work around but just wanted to note this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a small fix to integer_spec so tests pass.