Fix filenames of two function spec tests #777
Conversation
|
@alexjfisher yo yo, totally agree with the rename, can you look at the failure, if not i will jump on it next week |
alexjfisher
force-pushed
the
fix_test_filenames
branch
2 times, most recently
from
6a9b4e7 to
fd9422d
Compare
The tests weren't being run. Total tests increase from 2742 to 2769.
Also fix 'when using a class extending String' test.
It had been failing with...
```
RuntimeError:
can't modify frozen AlsoString
```
alexjfisher
force-pushed
the
fix_test_filenames
branch
from
fd9422d to
2220810
Compare
|
@tphoney I fixed up one of the tests and now the travis build passes. Appveyor is still failing for puppet 4.2. Looks like the error messages aren't the same for older and new versions of puppet. These are the tests that fail. puppetlabs-stdlib/spec/functions/length.rb Lines 5 to 8 in 5a17bf1 |
| @@ -26,10 +26,6 @@ | |||
| it { is_expected.to run.with_params('āβćđ').and_return(4) } | |||
|
|
|||
| context 'when using a class extending String' do | |||
| it 'should call its size method' do | |||
| value = AlsoString.new('asdfghjkl') | |||
| value.expects(:length).returns('foo') | |||
There was a problem hiding this comment.
I'm not sure it ever made any sense to mock returning a string when the function should only ever return an int.
|
Thanks for the changes @alexjfisher ,agreed with your conclusion. I am looking into weird appveryor ness at the minute. Hopefully i will get something merged soon. |
|
Thanks for the PR, stdlib is failing but not because of this. merging |
These tests weren't being run. Total tests increase from 2742 to 2769.