Skip to content

(maint) Stdlib::Compat::Integer accepts numbers with newlines apparently #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2017
Merged

(maint) Stdlib::Compat::Integer accepts numbers with newlines apparently #756

merged 1 commit into from
Jul 7, 2017

Conversation

hunner
Copy link
Contributor

@hunner hunner commented Apr 14, 2017

No description provided.

@rnelson0
Copy link
Contributor

puppetlabs-stdlib/lib/puppet/parser/functions/is_integer.rb

Line 36 in e4ea1c4

numeric = %r{^-?(?:(?:[1-9]\d*)|0)$}
- in 123\456, the $ matches the \n and ignores everything after that. Hooray!

@hunner hunner force-pushed the newline_integers branch from 2a5353f to c4d84d4 Compare April 14, 2017 18:46
@eputnam
Copy link
Contributor

eputnam commented Apr 17, 2017

@hunner would you mind adding a commit message? something like "#thisisfine so we're just updating tests"

@tphoney tphoney merged commit 4c1b51c into puppetlabs:master Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hunner @rnelson0 @eputnam @tphoney @jordanbreen28