Skip to content

Add validate_domain_name function #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Add validate_domain_name function #753

merged 1 commit into from
Jul 31, 2017

Conversation

frapex
Copy link
Contributor

@frapex frapex commented Mar 29, 2017

Add validate_domain_name function.

@tphoney
Copy link
Contributor

tphoney commented Jul 7, 2017

I am struggling to see how this is different to https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/puppet/parser/functions/is_domain_name.rb can you explain ?

@frapex
Copy link
Contributor Author

frapex commented Jul 8, 2017

For almost every is_something function there is also a validate_something function (is_absolute_path and validate_absolute_path, is_email_address and validate_ip_address, et cetera)

There is no validate function available for the is_domain_name function. This commit adds the missing validate_domain_name function.

@frapex
Copy link
Contributor Author

frapex commented Jul 26, 2017

@tphoney can you please look at this pull request and merge it? It has been almost four months since the pull request was first created and almost three weeks since I added additional info and rebased.

@tphoney tphoney merged commit 48a8f76 into puppetlabs:master Jul 31, 2017
@tphoney
Copy link
Contributor

tphoney commented Jul 31, 2017

Thanks for this @frapex apologies for the delay, i was stuck on other things.

@frapex
Copy link
Contributor Author

frapex commented Aug 1, 2017

@tphoney thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants