Update for new gem version of puppetlabs_spec_helper #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the Rakefile and spec_helper to use the common versions available in the puppetlabs_spec_helper rubygem branch. This mostly just removes a bunch of duplicated code, but it also gives us more flexibility in how the module is tested in the future.
| RSpec::Core::RakeTask.new(:coverage) do |t| | ||
| t.rcov = true | ||
| t.rcov_opts = ['--exclude', 'spec'] | ||
| end |
|
This is great. I really wanted to do this when I was working on puppetlabs_spec_helper a few months ago but didn't get a chance. I think there are a couple of minor kinks to work out in the pull request to puppetlabs_spec_helper itself before this can go through, but this is fantastic. |
cprice404
added a commit
that referenced
this pull request
Jun 27, 2012
Update for new gem version of puppetlabs_spec_helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Rakefile and spec_helper to use the common versions available in the puppetlabs_spec_helper rubygem branch. This mostly just removes a bunch of duplicated code, but it also gives us more flexibility in how the module is tested in the future.
The
.gemspechas been tested using Travis-CI, and the tests are confirmed to work correctly in that environment