Skip to content

MODULES-3699 fixes deprecation msg test #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eputnam
Copy link
Contributor

@eputnam eputnam commented Aug 26, 2016

The changed test originally created a file called /tmp/deprecation, which was not referenced anywhere else in the module and wasn't actually being used by the test except to run the catalog. Instead of going through changing the file location to better accommodate solaris and windows, I changed to a notify resource instead. It does the same thing as the file resource did for the test but is far less breakable.

@bmjen
Copy link
Contributor

bmjen commented Aug 29, 2016

@eputnam, can you add a description to the PR explaining why replacing the actual file resource with a notify is the fix? The notify itself doesn't really contribute anything to the test

@DavidS
Copy link
Contributor

DavidS commented Aug 30, 2016

  1. to add the fix description to the commit, you'll need to "git commit --amend" to record the message in the actual git structure, and not only on github

  2. the tests did use the file to ascertain that the resources was/was not created. Just removing that part weakens the test.

@eputnam
Copy link
Contributor Author

eputnam commented Sep 1, 2016

cancelled in favor of #646

@eputnam eputnam closed this Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants