catch StandardError rather than the gratuitous Exception #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Good catch @ffrank ! |
|
The casualty of this change was See #589 for a fix. |
|
Oh wow, so it raises as though someone tried to load invalid Ruby code at runtime. Not sure that's a sound design. Cool workaround though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching
Exceptionis gratuitous and makes Ruby behave weirdly in case of badly timed SIGINTs, SIGTERMs etc.All proper errors should descend from
StandardErrorrather thanExceptiondirectly (Puppet::Errordoes this). Catching those is much less problematic.