Extend Base64() function support #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is excellent, and so are the tests 👍 |
|
@tphoney edited, please review it again, thanks! |
|
apologies for being needy, could you squash the commits. |
|
@tphoney done! let's wait for CI test result 👍 |
|
awesome !! |
tphoney
added a commit
that referenced
this pull request
Feb 18, 2016
Extend Base64() function support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend base64() function to fit rfc2045 (original), and rfc4648
allow user to specify encode/decode method to use, including "default", "strict", "urlsafe"
reference: