Skip to content

Update README #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2014
Merged

Update README #391

merged 1 commit into from
Dec 21, 2014

Conversation

petems
Copy link
Contributor

@petems petems commented Dec 19, 2014

MODULES-1582 change, MODULES-444 change and Whitespace fixes

@hunner
Copy link
Contributor

hunner commented Dec 19, 2014

Oh right! Thanks @petems ; could you rebase it though? It has a merge conflict.

* `concat`: Appends the contents of array 2 onto array 1. For example, `concat(['1','2','3'],'4')` results in: ['1','2','3','4']. *Type*: rvalue
* `concat`: Appends the contents of multiple arrays onto array 1. For example:
* `concat(['1','2','3'],'4')` results in: ['1','2','3','4'].
* `concat(['1','2','3'],'4'['5','6','7'])` results in: ['1','2','3','4','5','6','7','].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be another comma after '4'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also an extra ,' in the result.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! 👍

* (MODULES-444) Update README for concat changes
* (MODULES-1582) Update `validate_cmd` readme
* Plus some Whitespace fixes
hunner added a commit that referenced this pull request Dec 21, 2014
@hunner hunner merged commit dcc9605 into puppetlabs:master Dec 21, 2014
@petems petems deleted the update_readme branch December 21, 2014 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants