Skip to content

Feature: allow array of pathes in validate_absolute_path #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Feature: allow array of pathes in validate_absolute_path #323

wants to merge 4 commits into from

Conversation

poikilotherm
Copy link
Contributor

Sorry for the reverted stuff in between, GitHub does not seem to allow me to exclude stuff from the PR once commited...

…ath, also extending rspec tests and documentation"

as I mixed up a file (validate_array)... grml.

This reverts commit 5889df7.
…o extending rspec tests and documentation (now for real)
@igalic
Copy link
Contributor

igalic commented Sep 24, 2014

why don't we just remove the check if the number of args is > 0?

in that case we wouldn't have to put our paths into arrays in the first place.

@poikilotherm
Copy link
Contributor Author

In my use case, it would be a great relief to have the possibility to use an array, as I throw stuff inside the check from hiera directly. And I can't think of a way to convert an array into function args within Puppet DSL...?

Why would you remove the check if # args > 0? This wouldn't change the behaviour of Puppet::Util.absolute_path to check on a String via reg. ex., or do I miss some understanding of Ruby special handling of function calls? (I'm not THAT familiar with Ruby...)

@poikilotherm
Copy link
Contributor Author

Hi there,
any chances for this being merged in the near future?
Should I change something?

@poikilotherm
Copy link
Contributor Author

I'll close this PR for now and create a separated squashed commit and a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants