Skip to content

Add a dirname function #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@ Would return: ['a','c']

- *Type*: rvalue

dirname
-------
Returns the `dirname` of a path.

*Examples:*

dirname('/path/to/a/file.ext')

Would return: '/path/to/a'

downcase
--------
Converts the case of a string or all strings in an array to lower case.
Expand Down
15 changes: 15 additions & 0 deletions lib/puppet/parser/functions/dirname.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
module Puppet::Parser::Functions
newfunction(:dirname, :type => :rvalue, :doc => <<-EOS
Returns the dirname of a path.
EOS
) do |arguments|

raise(Puppet::ParseError, "dirname(): Wrong number of arguments " +
"given (#{arguments.size} for 1)") if arguments.size < 1

path = arguments[0]
return File.dirname(path)
end
end

# vim: set ts=2 sw=2 et :
24 changes: 24 additions & 0 deletions spec/unit/puppet/parser/functions/dirname_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#! /usr/bin/env ruby -S rspec
require 'spec_helper'

describe "the dirname function" do
let(:scope) { PuppetlabsSpec::PuppetInternals.scope }

it "should exist" do
Puppet::Parser::Functions.function("dirname").should == "function_dirname"
end

it "should raise a ParseError if there is less than 1 arguments" do
lambda { scope.function_dirname([]) }.should( raise_error(Puppet::ParseError))
end

it "should return dirname for an absolute path" do
result = scope.function_dirname(['/path/to/a/file.ext'])
result.should(eq('/path/to/a'))
end

it "should return dirname for a relative path" do
result = scope.function_dirname(['path/to/a/file.ext'])
result.should(eq('path/to/a'))
end
end