Skip to content

Namespace Puppet 4.x functions #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 30, 2023
Merged

Namespace Puppet 4.x functions #1356

merged 20 commits into from
May 30, 2023

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented May 16, 2023 •
edited
Loading

@puppet-community-rangefinder
Copy link

batch_escape is a function

that may have no external impact to Forge modules.

ensure_packages is a function

Breaking changes to this file MAY impact these 552 modules (near match):

fqdn_rand_string is a function

Breaking changes to this file MAY impact these 23 modules (near match):

has_interface_with is a function

Breaking changes to this file MAY impact these 8 modules (near match):

merge is a function

Breaking changes to this file MAY impact these 315 modules (near match):

os_version_gte is a function

that may have no external impact to Forge modules.

parsehocon is a function

that may have no external impact to Forge modules.

parsepson is a function

that may have no external impact to Forge modules.

powershell_escape is a function

that may have no external impact to Forge modules.

seeded_rand is a function

Breaking changes to this file MAY impact these 6 modules (near match):

seeded_rand_string is a function

Breaking changes to this file MAY impact these 4 modules (near match):

shell_escape is a function

Breaking changes to this file MAY impact these 13 modules (near match):

stdlib::batch_escape is a function

that may have no external impact to Forge modules.

stdlib::ensure_packages is a function

that may have no external impact to Forge modules.

stdlib::fqdn_rand_string is a function

that may have no external impact to Forge modules.

stdlib::merge is a function

that may have no external impact to Forge modules.

stdlib::os_version_gte is a function

that may have no external impact to Forge modules.

stdlib::parsehocon is a function

that may have no external impact to Forge modules.

stdlib::parsepson is a function

that may have no external impact to Forge modules.

stdlib::powershell_escape is a function

that may have no external impact to Forge modules.

stdlib::seeded_rand is a function

that may have no external impact to Forge modules.

stdlib::seeded_rand_string is a function

that may have no external impact to Forge modules.

stdlib::shell_escape is a function

that may have no external impact to Forge modules.

stdlib::to_json is a function

that may have no external impact to Forge modules.

stdlib::to_json_pretty is a function

that may have no external impact to Forge modules.

stdlib::to_python is a function

that may have no external impact to Forge modules.

stdlib::to_ruby is a function

that may have no external impact to Forge modules.

stdlib::to_toml is a function

that may have no external impact to Forge modules.

stdlib::to_yaml is a function

that may have no external impact to Forge modules.

This module is declared in 318 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@smortex smortex force-pushed the namespace-puppet4-functions branch 2 times, most recently from 9c63f89 to d8a65fe Compare May 16, 2023 19:34
@smortex smortex force-pushed the namespace-puppet4-functions branch from d8a65fe to e7e3366 Compare May 24, 2023 18:14
smortex added 5 commits May 24, 2023 08:34
@smortex
Add a function to update / regenerate deprecated shims
14b4150 
In order to move existing unamespaced functions to the stdlib namespace
(puppetlabs#1346) without breaking backwards compatibility, we need some
compatibility shims.  They will all look-like the same, so add a rake
task to regenerate them if we need to update them.
@smortex
Namespace function powershell_escape()
5d50a8e
@smortex
Namespace function validate_domain_name()
82f1a65
@smortex
Namespace function to_yaml()
10e87d8
@smortex
Namespace function to_python()
736aa24
@smortex smortex force-pushed the namespace-puppet4-functions branch from e7e3366 to 549e9c9 Compare May 24, 2023 18:57
@smortex smortex force-pushed the namespace-puppet4-functions branch from 549e9c9 to de89c7f Compare May 24, 2023 19:10
@LukasAud LukasAud mentioned this pull request May 25, 2023
Merged
@LukasAud
Copy link
Contributor

Hey @smortex, we have finally have completed our maintenance on Stdlib and we are getting ready to cut a major release for the module. This change looks like it would fall under backwards-incompatible and thus, if not merged before the release, there is a high chance it will sit around for a good while before we merge it.

Can you give us an update on the state of the PR and whether you are interested in continuing to work on it?

@smortex
Copy link
Collaborator Author

smortex commented May 25, 2023 •
edited
Loading

@LukasAud as it is now it feels almost ready to me, but there are still a few points that may deserve attention. They are listed in #1346, and that's why this is currently a draft.

Edit: more precisely in #1346 (comment)

@smortex smortex marked this pull request as ready for review May 29, 2023 01:02
@smortex smortex requested review from a team, alexjfisher, b4ldr, bastelfreak and ekohl as code owners May 29, 2023 01:02
LukasAud
LukasAud approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 390d47a into puppetlabs:main May 30, 2023
@smortex smortex deleted the namespace-puppet4-functions branch May 30, 2023 16:24
@seanmil seanmil mentioned this pull request Jul 22, 2023
Merged
3 tasks
@XMol XMol mentioned this pull request Nov 7, 2023
Open
deric added a commit to deric/puppet-resolv_conf that referenced this pull request Jun 21, 2024
@deric
Use stdlib:: namespace prefix for puppet 4.x function
b8539fe 
This change requires stdlib >= 9
puppetlabs/puppetlabs-stdlib#1356
@deric deric mentioned this pull request Jun 21, 2024
Merged
deric added a commit to deric/puppet-resolv_conf that referenced this pull request Jun 21, 2024
@deric
Use stdlib:: namespace prefix for puppet 4.x function
245f96d 
This change requires stdlib >= 9
puppetlabs/puppetlabs-stdlib#1356
saz pushed a commit to saz/puppet-resolv_conf that referenced this pull request Jun 24, 2024
@deric @saz
Use stdlib:: namespace prefix for puppet 4.x function
6fefe2b 
This change requires stdlib >= 9
puppetlabs/puppetlabs-stdlib#1356
deric added a commit to deric/puppetlabs-kubernetes that referenced this pull request Jun 27, 2024
@deric
Use namespaced puppet 4.x functions
a1d727e 
This change requires puppetlabs/stdlib >= 9

See puppetlabs/puppetlabs-stdlib#1356
@deric deric mentioned this pull request Jun 27, 2024
Open
3 tasks
treydock pushed a commit to treydock/puppetlabs-kubernetes that referenced this pull request Oct 19, 2024
@deric @treydock
Use namespaced puppet 4.x functions
b32d24e 
This change requires puppetlabs/stdlib >= 9

See puppetlabs/puppetlabs-stdlib#1356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelnak chelnak chelnak approved these changes

@LukasAud LukasAud LukasAud approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@b4ldr b4ldr Awaiting requested review from b4ldr b4ldr is a code owner

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Convert all Puppet 4.x API functions to namespaced variants
4 participants
@smortex @LukasAud @chelnak @ia-content