Remove deprecated functions

[smortex]

This PR remove a bunch of legacy functions that are now part of Puppet or which where added to stdlib to allow parameters validation prior to Puppet 4 introduction of data types.

All these functions produced deprecation warnings.

Nots:

• The has_interface_with() function deprecation was excluded because it is a "new" deprecation due to the function being namespaced (see RFC: Convert all Puppet 4.x API functions to namespaced variants #1346 for details).
• The validate_legacy() function was also kept. It is not used anymore by the module, but prior to removing it we may want to deprecate it.

[smortex]

[RFC] I started some research to determine how we should remove validate_legacy().

It appear that while there are a lot of calls to these functions into the wild, they are from numerous vendors and the "puppet-centric-shops" are quite good students with few usage of it 💯:

• Puppetlabs, 1 module affected:
  • puppetlabs/puppetlabs-wsus_client
• Voxpupuli, 1 module affected:
  • voxpupuli/puppet-dropbear

Context

validate_legacy() was used with a data type and a validation function. If the value was matched by both the data type and the validation function, it produced no warning, otherwise it produced a warning if the new data type was matched but the legacy validation function was not accepting the value or an deprecation message if the data type was not matched but the legacy validation was accepted. The validation functions used are the ones being removed by this PR, so validate_legacy() needs to be taken care of.

The table bellow summarize the current behavior of validate_legacy():

Data Type	Legacy function	result
✔️ pass	✔️ pass	✔️ pass
✔️ pass	❌ fail	⚠️ notice (Accepting previously invalid value for target type)
❌ fail	✔️ pass	⚠️ deprecation(validate_legacy)
❌ fail	❌ fail	❌ fail

Assumptions

The last line (fail/fail) is not expected to be seen into the wild because the compilation failure makes modules unusable.

For the 3 first line, only the first one does not produce annoying deprecation warning / notice, so we expect that such issues have been fixed.

Proposal

Update the function to always emit a deprecation message, and only validate the value against the provided data type. The validation function is therefore completely ignored (but the function prototype is not changed for backwards compatibility).

The table bellow summarize the proposed behavior of validate_legacy():

Data Type	Legacy function	result
✔️ pass	❔ ignored	⚠️ deprecation(replace validate_legacy() with data type)
❌ fail	❔ ignored	❌ fail

[LukasAud]

LGTM

[traylenator]

Amazing is_integer('1234') with a string used to be true , Pattern[/\d+/] it is.

[smortex]

D'oh! The case for #1352 (comment) was still unresolved 🙃 (maybe I should have made this a draft).

Looks like I had a 🚀 reaction that might indicate it makes sense, so I'll fill in a PR with the proposed change and we will be able to focus on this discussion there. Will do this when I reach $WORK later today.