Skip to content

Add floor function implementation and unit tests #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions README.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,20 @@ as a result.
Would return: ['a','b','c']


- *Type*: rvalue

floor
-----
Returns the largest integer less or equal to the argument.
Takes a single numeric value as an argument.

*Examples:*

floor('3.8')

Would return: '3'


- *Type*: rvalue

fqdn_rotate
Expand Down
20 changes: 20 additions & 0 deletions lib/puppet/parser/functions/floor.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module Puppet::Parser::Functions
newfunction(:floor, :type => :rvalue, :doc => <<-EOS
Returns the largest integer less or equal to the argument.
Takes a single numeric value as an argument.
EOS
) do |arguments|

raise(Puppet::ParseError, "floor(): Wrong number of arguments " +
"given (#{arguments.size} for 1)") if arguments.size != 1

arg = arguments[0]

raise(Puppet::ParseError, "floor(): Wrong argument type " +
"given (#{arg.class} for Numeric)") if arg.is_a?(Numeric) == false

arg.floor
end
end

# vim: set ts=2 sw=2 et :
39 changes: 39 additions & 0 deletions spec/unit/puppet/parser/functions/floor_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
#! /usr/bin/env ruby -S rspec

require 'spec_helper'

describe "the floor function" do
let(:scope) { PuppetlabsSpec::PuppetInternals.scope }

it "should exist" do
Puppet::Parser::Functions.function("floor").should == "function_floor"
end

it "should raise a ParseError if there is less than 1 argument" do
lambda { scope.function_floor([]) }.should( raise_error(Puppet::ParseError, /Wrong number of arguments/))
end

it "should should raise a ParseError if input isn't numeric (eg. String)" do
lambda { scope.function_floor(["foo"]) }.should( raise_error(Puppet::ParseError, /Wrong argument type/))
end

it "should should raise a ParseError if input isn't numeric (eg. Boolean)" do
lambda { scope.function_floor([true]) }.should( raise_error(Puppet::ParseError, /Wrong argument type/))
end

it "should return an integer when a numeric type is passed" do
result = scope.function_floor([12.4])
result.is_a?(Integer).should(eq(true))
end

it "should return the input when an integer is passed" do
result = scope.function_floor([7])
result.should(eq(7))
end

it "should return the largest integer less than or equal to the input" do
result = scope.function_floor([3.8])
result.should(eq(3))
end
end