Remove deprecated is_absolute_path function #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyEwings
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
is_absolute_path is a functionBreaking changes to this file MAY impact these 4 modules (near match):is_absolute_path is a functionBreaking changes to this file MAY impact these 4 modules (near match):This module is declared in 318 of 580 indexed public
|
|
Same as I say in another PR, while I agree with the removal, I do think we could go further and drop the compat data types too. These are basically the standard data types with bug-to-bug compatibility with the old functions if I recall correctly. |
bastelfreak
approved these changes
Apr 26, 2023
openstack-mirroring
pushed a commit
to openstack/puppet-horizon
that referenced
this pull request
May 5, 2023
The Stdlib::Absolutepath which was deprecated 4 years ago is now removed since [1]. We replace it by the Stdlib::Compat::Absolute_path [2] data type which contains the same functions "is_absolute_path" and "validate_absolute_path". [1] puppetlabs/puppetlabs-stdlib#1324 [2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path Change-Id: I0fa697cf5e46b7214dca7940d19be81203eed70d
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 5, 2023
* Update puppet-horizon from branch 'master'
to 92950a690d6d73a5938da117be6812b2663e27b6
- Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path
The Stdlib::Absolutepath which was deprecated 4 years ago is
now removed since [1]. We replace it by the
Stdlib::Compat::Absolute_path [2] data type which contains the
same functions "is_absolute_path" and "validate_absolute_path".
[1] puppetlabs/puppetlabs-stdlib#1324
[2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path
Change-Id: I0fa697cf5e46b7214dca7940d19be81203eed70d
openstack-mirroring
pushed a commit
to openstack-archive/puppet-qdr
that referenced
this pull request
May 5, 2023
The Stdlib::Absolutepath which was deprecated 4 years ago is now removed since [1]. We replace it by the Stdlib::Compat::Absolute_path [2] data type which contains the same functions "is_absolute_path" and "validate_absolute_path". [1] puppetlabs/puppetlabs-stdlib#1324 [2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path Change-Id: Iec51d93025702a40b2f2be45a655eded125f1ab5
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 5, 2023
* Update puppet-qdr from branch 'master'
to 9a7a6c3f43b1a65d4cb8178d31915795d7e0d0e1
- Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path
The Stdlib::Absolutepath which was deprecated 4 years ago is
now removed since [1]. We replace it by the
Stdlib::Compat::Absolute_path [2] data type which contains the
same functions "is_absolute_path" and "validate_absolute_path".
[1] puppetlabs/puppetlabs-stdlib#1324
[2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path
Change-Id: Iec51d93025702a40b2f2be45a655eded125f1ab5
openstack-mirroring
pushed a commit
to openstack/puppet-openstacklib
that referenced
this pull request
May 7, 2023
The Stdlib::Absolutepath which was deprecated 4 years ago is now removed since [1]. We replace it by the Stdlib::Compat::Absolute_path [2] data type which contains the same functions "is_absolute_path" and "validate_absolute_path". [1] puppetlabs/puppetlabs-stdlib#1324 [2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path Change-Id: I57108b7e4a0525444dbbd36d6a9086e374a45539
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 7, 2023
* Update puppet-openstacklib from branch 'master'
to 0861e31cf9e3d4cb6022038f46caf3cdc5f83873
- Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path
The Stdlib::Absolutepath which was deprecated 4 years ago is
now removed since [1]. We replace it by the
Stdlib::Compat::Absolute_path [2] data type which contains the
same functions "is_absolute_path" and "validate_absolute_path".
[1] puppetlabs/puppetlabs-stdlib#1324
[2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path
Change-Id: I57108b7e4a0525444dbbd36d6a9086e374a45539
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 10, 2023
* Update puppet-keystone from branch 'master'
to 6c2a1617219c706aa511ee44a5337534c05ae460
- Merge "Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path"
- Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path
The Stdlib::Absolutepath which was deprecated 4 years ago is
now removed since [1]. We replace it by the
Stdlib::Compat::Absolute_path [2] data type which contains the
same functions "is_absolute_path" and "validate_absolute_path".
[1] puppetlabs/puppetlabs-stdlib#1324
[2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path
Change-Id: I8ad2395f14058fecbb7868f081fa2dfdf5f199cc
openstack-mirroring
pushed a commit
to openstack/puppet-keystone
that referenced
this pull request
May 10, 2023
The Stdlib::Absolutepath which was deprecated 4 years ago is now removed since [1]. We replace it by the Stdlib::Compat::Absolute_path [2] data type which contains the same functions "is_absolute_path" and "validate_absolute_path". [1] puppetlabs/puppetlabs-stdlib#1324 [2] https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#Stdlib--Compat--Absolute_path Change-Id: I8ad2395f14058fecbb7868f081fa2dfdf5f199cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecated 4 years ago
use match expressions with Stdlib::Compat::Absolute_Path instead. They are described at https://docs.puppet.com/puppet/latest/reference/lang_data_type.html#match-expressions.