Skip to content

Remove deprecated hash function #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

Remove deprecated hash function #1320

merged 1 commit into from
Apr 25, 2023

Conversation

MartyEwings
Copy link
Contributor

Note: This function has been replaced with the built-in ability to create a new value of almost any
data type - see the built-in Hash.new function
in Puppet.
This example shows the equivalent expression in the Puppet language:
Hash(['a',1,'b',2,'c',3]) Hash([['a',1],['b',2],['c',3]])

@puppet-community-rangefinder
Copy link

hash is a function

Breaking changes to this file MAY impact these 29 modules (near match):

This module is declared in 318 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

LukasAud
LukasAud approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 39f1e80 into puppetlabs:main Apr 25, 2023
openstack-mirroring pushed a commit to openstack/puppet-horizon that referenced this pull request May 4, 2023
@jcapiitao
Replace stdlib hash function by the built-in Puppet one
439ce39 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id562cf4aa8cae94ae537ff239fac946884940082
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request May 4, 2023
@jcapiitao @openstack-gerrit
Update git submodules
6b1b287 
* Update puppet-horizon from branch 'master'
  to 439ce39e1a8e8592a2930931e162deff7a1ee0f7
  - Replace stdlib hash function by the built-in Puppet one
    
    The upstream patch [1] removed the hash stdlib function which was
    deprecated since a while. We should now use the Puppet built-in
    function Hash().
    
    [1] puppetlabs/puppetlabs-stdlib#1320
    
    Change-Id: Id562cf4aa8cae94ae537ff239fac946884940082
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request May 5, 2023
@jcapiitao @openstack-gerrit
Update git submodules
3947284 
* Update puppet-openstacklib from branch 'master'
  to e05c8e739ba4a509ad48905f5f575e344fcc2658
  - Replace stdlib hash function by the built-in Puppet one
    
    The upstream patch [1] removed the hash stdlib function which was
    deprecated since a while. We should now use the Puppet built-in
    function Hash().
    
    [1] puppetlabs/puppetlabs-stdlib#1320
    
    Change-Id: Id6e2b70cd1a4472caee324e94a674cfe24cd6a9e
openstack-mirroring pushed a commit to openstack/puppet-openstacklib that referenced this pull request May 5, 2023
@jcapiitao
Replace stdlib hash function by the built-in Puppet one
e05c8e7 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id6e2b70cd1a4472caee324e94a674cfe24cd6a9e
sjjf pushed a commit to NCI-Cloud/puppet-openstacklib that referenced this pull request Jun 7, 2024
@jcapiitao @sjjf
Replace stdlib hash function by the built-in Puppet one
1b3c121 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id6e2b70cd1a4472caee324e94a674cfe24cd6a9e
sjjf pushed a commit to NCI-Cloud/puppet-openstacklib that referenced this pull request Jun 7, 2024
@jcapiitao @sjjf
Replace stdlib hash function by the built-in Puppet one
78f4da4 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id6e2b70cd1a4472caee324e94a674cfe24cd6a9e
sjjf pushed a commit to NCI-Cloud/puppet-horizon that referenced this pull request Jun 7, 2024
@jcapiitao @sjjf
Replace stdlib hash function by the built-in Puppet one
89844d4 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id562cf4aa8cae94ae537ff239fac946884940082
sjjf pushed a commit to NCI-Cloud/puppet-horizon that referenced this pull request Jun 18, 2024
@jcapiitao @sjjf
Replace stdlib hash function by the built-in Puppet one
10a3158 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id562cf4aa8cae94ae537ff239fac946884940082
david-monro-ANU pushed a commit to NCI-Cloud/puppet-openstacklib that referenced this pull request Feb 26, 2025
@jcapiitao @david-monro-ANU
Replace stdlib hash function by the built-in Puppet one
5fedae2 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id6e2b70cd1a4472caee324e94a674cfe24cd6a9e
david-monro-ANU pushed a commit to NCI-Cloud/puppet-horizon that referenced this pull request Feb 26, 2025
@jcapiitao @david-monro-ANU
Replace stdlib hash function by the built-in Puppet one
f97f350 
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().

[1] puppetlabs/puppetlabs-stdlib#1320

Change-Id: Id562cf4aa8cae94ae537ff239fac946884940082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@LukasAud LukasAud LukasAud approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@b4ldr b4ldr Awaiting requested review from b4ldr b4ldr is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartyEwings @bastelfreak @LukasAud