(#8925) Added new function called 'get_certificate' for retrieving #13
Conversation
certificates from a CA (or locally). This function works by either obtaining the file locally or remotely based on Puppets configuration. Also added get_pubkey which wraps get_certificate and extracts the public key.
| end | ||
| else | ||
| # Obtain the certificate from the CA if its remote | ||
| # TODO: wrap: puppet certificate --render-as s --ca-location local find [email protected] |
There was a problem hiding this comment.
You should be able to do this with the Ruby API for the face, vis Puppet::Face[:certificate, '0.0.1'].find('[email protected]'). That should return a useful Ruby object back to you.
There was a problem hiding this comment.
Yeah - I figured that but I was aiming for 2.6.x support as well ... I experimented with deeper API's on both but figured it wasn't a clean way of doing it.
There was a problem hiding this comment.
Ah, cool. Merge away, then. :)
|
I honestly can't tell if this is the right approach or not to the problem. The code looks correct and reasonable to me, and I don't object to it, but I want another confirmation from someone before it merges. (Sorry, Ken. Not a criticism; I think I would have done it the same way. :) |
(#8925) Added new function called 'get_certificate' for retrieving
* ticket/master/revert_8925: (#10007) Revert "Merge pull request #13 from kbarber/issue/master/8925-user_ssl_certs"
certificates from a CA (or locally).
This function works by either obtaining the file locally
or remotely based on Puppets configuration.
Also added get_pubkey which wraps get_certificate and extracts the
public key.