FM-1556 Add ability to manage login server level permissions #72
Conversation
cyberious
changed the title
cyberious
changed the title
|
Thought there was a bug, was not, it was an issue with test login having svrroles that caused failure. |
|
|
||
| ## Validate state | ||
| $_state = upcase($state) | ||
| validate_re($_state,'^(GRANT|REVOKE|DENY)$', "State can only be of 'GRANT', 'REVOKE' or 'DENY' you passed ${state}") |
|
Added a note to the ticket about getting a capture of successful manifest runs against SQL Server since there are no acceptance tests. |
| # The login for which the permission will be manage. | ||
| # | ||
| # [permission] | ||
| # The permission you would like managed. i.e. 'SELECT', 'INSERT', 'UPDATE', 'DELETE' |
There was a problem hiding this comment.
What about EXECUTE? Nevermind, these are examples.
There was a problem hiding this comment.
Please update documentation - this is permissions now.
There was a problem hiding this comment.
This is still not updated.
|
Nothing really jumps out at me as inherently bad here. Just small tweaks and of course the CASCADE thing. |
|
Requires #74 for tests to pass |
|
@ferventcoder @Iristyle Here is the latest, I modified last night to be able to pass an array of permissions instead of individual ones. This applies to both Login and User permissions. |
| SET @permission = '<%= permission %>' | ||
| <%= scope.function_template(['sqlserver/snippets/login/permission/exists.sql.erb']) %> | ||
| <% end %> | ||
| END |
There was a problem hiding this comment.
Same comment from #71 about the double loop.
There was a problem hiding this comment.
Updated to single loop
|
Same deal here with documentation. Get that updated and this is |
|
@ferventcoder docs updated |
No description provided.