FM-1898 Add sqlserver::user::permssion with GRANT, REVOKE and DENY #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberious
changed the title
hunner
added a commit
that referenced
this pull request
Feb 18, 2015
FM-1898 Add sqlserver::user::permssion with GRANT, REVOKE and DENY
| <%= @_state %> <%= @_permission %> TO [<%= @user %>]; | ||
| END | ||
| BEGIN | ||
| <%= scope.function_template(['sqlserver/query/user_permission_exists.sql.erb']) %> |
There was a problem hiding this comment.
Interesting. I wouldn't have thought in module you would need to namespace it. TIL
There was a problem hiding this comment.
I believe when calling from another template you have to. Inside a Puppet Policy file however that might be different.
|
Other than it appears the perms are very broad, it looks good. |
|
Actually thinking about this more - In SQL Server the best practice is to give perms to a role and put users in that role. |
|
I agree and think we should manage roles and permissions in future as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.