Skip to content

[CAT-1065] : Removing support for SQL Server 2012 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

[CAT-1065] : Removing support for SQL Server 2012 #455

merged 1 commit into from
Sep 1, 2023

Conversation

rajat-puppet
Copy link
Contributor

Summary

Removing support for EOL SQL Server 2012

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@rajat-puppet rajat-puppet marked this pull request as ready for review August 31, 2023 06:56
@rajat-puppet rajat-puppet requested a review from a team as a code owner August 31, 2023 06:56
@malikparvez
Copy link
Member

Could you clean up the commits

@rajat-puppet rajat-puppet force-pushed the CAT-1065-drop-sqlserver2012 branch from 7b06594 to 170ddc9 Compare August 31, 2023 11:03
@rajat-puppet
Copy link
Contributor Author

Could you clean up the commits

Done.

malikparvez
malikparvez approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@malikparvez malikparvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malikparvez malikparvez merged commit d4f706c into main Sep 1, 2023
@malikparvez malikparvez deleted the CAT-1065-drop-sqlserver2012 branch September 1, 2023 05:06
@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Sep 3, 2023 •
edited
Loading

@rajat-puppet don't want to jump in here but just happened to stumble across it. I would suggest rethinking the labelling of this change, it is more-than-likely backwards-incompatible as this PR is removing support and compatibility for sqlserver 2012, thus should at the very least have a section in the release notes (this will not be generated when the label is maintenance).

@rajat-puppet
Copy link
Contributor Author

@rajat-puppet don't want to jump in here but just happened to stumble across it. I would suggest rethinking the labelling of this change, it is more-than-likely backwards-incompatible as this PR is removing support and compatibility for sqlserver 2012, thus should at the very least have a section in the release notes (this will not be generated when the label is maintenance).

Thanks for the information. I wasn’t aware of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malikparvez malikparvez malikparvez approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajat-puppet @malikparvez @jordanbreen28