Skip to content

(CONT-370) Reinstate lost sqlserver documentation on feature & tool deprecations #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022
Merged

(CONT-370) Reinstate lost sqlserver documentation on feature & tool deprecations #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/puppet/type/sqlserver_features.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@
end

newproperty(:features, array_matching: :all) do
desc 'Specifies features to install, uninstall, or upgrade. The list of top-level features include
BC, Conn, SSMS, ADV_SSMS, SDK, IS and MDS.'
desc "Specifies features to install, uninstall, or upgrade. The list of top-level features include
BC, Conn, SSMS, ADV_SSMS, SDK, IS and MDS.

The 'Tools' feature is deprecated. Instead specify 'BC', 'SSMS', 'ADV_SSMS', 'Conn', and 'SDK' explicitly."
newvalues(:Tools, :BC, :Conn, :SSMS, :ADV_SSMS, :SDK, :IS, :MDS, :BOL, :DREPLAY_CTLR, :DREPLAY_CLT, :DQC)
munge do |value|
if PuppetX::Sqlserver::ServerHelper.is_super_feature(value)
Expand Down
6 changes: 4 additions & 2 deletions lib/puppet/type/sqlserver_instance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@
end

newproperty(:features, array_matching: :all) do
desc 'Specifies features to install, uninstall, or upgrade. The list of top-level features include
SQLEngine, Replication, FullText, DQ AS, and RS.'
desc "Specifies features to install, uninstall, or upgrade. The list of top-level features include
SQLEngine, Replication, FullText, DQ AS, and RS.

The 'SQL' feature is deprecated. Instead specify 'DQ', 'FullText', 'Replication', and 'SQLEngine' explicitly."
newvalues(:SQL, :SQLEngine, :Replication, :FullText, :DQ, :AS, :RS, :POLYBASE, :ADVANCEDANALYTICS)
munge do |value|
if PuppetX::Sqlserver::ServerHelper.is_super_feature(value)
Expand Down