(MODULES-5472) Login values can now be passed as sensitive strings #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admin_user, admin_pass and password can now be passed as sensitive strings in order to prevent them from being leaked within the logs.
|
|
sqlserver::config is a typethat may have no external impact to Forge modules. sqlserver::login is a typethat may have no external impact to Forge modules. This module is declared in 3 of 578 indexed public
|
Have updated several test's throughout the codebase to use the new sensitive value for admin_user, admin_pass and password as proof of concept.
adrianiurca
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin_user, admin_pass and password can now be passed as sensitive strings in order to prevent them from being leaked within the logs.