(MODULES-7553) Add Example Clarification #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user trying to follow our advanced example ran into an issue. The example as written is only suitable for setups that are using local accounts, not domain accounts. They also found that the Facter fact `domain` returns the FQDN of the domain, which is not suitable for contsructing user names in the `netbiosname\username` format. This change adds a clarification to the example that the example is only usable when using local group, and given that there is no `netbiosname` fact available, provides a suggestion for one way to work around the issue.
michaeltlombardi
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user trying to follow our advanced example ran into an issue. The
example as written is only suitable for setups that are using local
accounts, not domain accounts. They also found that the Facter fact
domainreturns the FQDN of the domain, which is not suitable forcontsructing user names in the
netbiosname\usernameformat.This change adds a clarification to the example that the example is only
usable when using local group, and given that there is no
netbiosnamefact available, provides a suggestion for one way to work around the
issue.