(MODULES-6582) Add ability to test against sql server 2017 #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThoughtCrhyme
force-pushed
the
MODULES-6582
branch
2 times, most recently
from
444105b to
995e4d6
Compare
RandomNoun7
previously approved these changes
Apr 10, 2019
| @@ -123,7 +123,7 @@ def sql_query_is_user_sysadmin(username) | |||
| ensure_sqlserver_instance(features, inst_name, 'absent') | |||
| end | |||
|
|
|||
| it "create #{inst_name} instance with only one RS feature", :tier_high => true do | |||
| it "create #{inst_name} instance with only one RS feature", :unless => version == '2017', :tier_high => true do | |||
There was a problem hiding this comment.
Should we consider casting to an int and doing a >= comparison here, so we don't have to jigger this line the next time we want to add a version?
| # TODO: Guard on SQL 2016 | ||
| it "'ADV_SSMS'", :unless => sql_version == '2016', :tier_low => true do | ||
| # TODO: Guard on SQL 2016 and 2017 | ||
| it "'ADV_SSMS'", :unless => sql_version == '2016' || '2017', :tier_low => true do |
There was a problem hiding this comment.
Same here. This line already has two specific versions. A third would start to look cludgy wouldn't it?
ThoughtCrhyme
force-pushed
the
MODULES-6582
branch
from
995e4d6 to
4199d04
Compare
ThoughtCrhyme
force-pushed
the
MODULES-6582
branch
from
4199d04 to
b99f957
Compare
RandomNoun7
approved these changes
Apr 11, 2019
RandomNoun7
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.