(maint) Spec fixes #273
Merged
(maint) Spec fixes #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prior code from 9b8a0fe used a non-obvious behavior in the mocking framework to return the Description value from an error instance. If the count of errors was returned was increased by 1, the code would be subtly wrong as mocks are generating to each call of .Errors(x) with the supplied values. - Instead, more clearly mock the actual code path, and additionally provide two separate messages, demonstrating they are iterated and joined properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior code from 9b8a0fe used a non-obvious
behavior in the mocking framework to return the Description value from an
error instance.
If the count of errors was returned was increased by 1, the code would be
subtly wrong as mocks are generating to each call of .Errors(x) with the
supplied values.
Instead, more clearly mock the actual code path, and additionally provide
two separate messages, demonstrating they are iterated and joined properly