(MODULES-6244) Update 2017 Support #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates README.md and metadata.json to reflect adding 2017 support
jpogran
approved these changes
Dec 6, 2017
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| ## Overview | |||
|
|
|||
| The sqlserver module installs and manages Microsoft SQL Server 2012, 2014 and 2016 on Windows systems. | |||
| The sqlserver module installs and manages Microsoft SQL Server 2012, 2014, 2016 and 2017 on Windows systems. | |||
There was a problem hiding this comment.
On the one hand, we'll have to keep updating this list forever. On the other hand, I'm inclined to believe that being super specific about supported versions is probably a good thing.
There was a problem hiding this comment.
It started super specific, so we're carrying on. You can create a DOCS ticket to change verbage if you want
| @@ -1068,6 +1068,8 @@ Terminology differs somewhat between various database systems; please refer to t | |||
|
|
|||
| ## Limitations | |||
|
|
|||
| SQL 2017 detection support has been added. This support is limited to functionality already present for other versions. No new SQL 2017 specific functionality has been added in this release. | |||
There was a problem hiding this comment.
We don't call it out here and I am not sure if we should, but we also don't make any particular effort to put up any safety rails for deprecated or altered features.
There was a problem hiding this comment.
We agreed that its fine as is, as we have upcoming work adding these features
michaeltlombardi
approved these changes
Dec 6, 2017
RandomNoun7
deleted the
ticket/master/MODULES-6244-update-documentation-2017
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates README.md and metadata.json to reflect adding 2017 support