(MODULES-5070) Add polybase parameters to sql_instance #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the PolyBase features were added to sql_instance however the config settings for username and password were not surfaced on the type. This commit: - Adds the polybase_svc_account and polybase_svc_password parameters to the sql_instance - Adds checks to the provider so an error is thrown if the polybase params are set, but no polybase feature is being installed - Previously the code assumed the puppet parameter names directly lined up with SQL Server installation command line switches however for Polybase, this is not true. This commit changes to using a simple lookup hashtable - This commit also removes a shared example called 'run' and install helper as they were not being used in any tests.
|
Running through adhoc |
|
Passed acceptance smoke tests. Ready for merge. |
jpogran
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the PolyBase features were added to sql_instance however the config
settings for username and password were not surfaced on the type. This commit:
sql_instance
set, but no polybase feature is being installed
SQL Server installation command line switches however for Polybase, this is
not true. This commit changes to using a simple lookup hashtable
they were not being used in any tests.