(MODULES-4915) Remove forced TCP connection for SQL management #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the module tried to connect to the SQL instance using the name localhost. This had the side effect of always using the TCP based connection. If a customer used a non-default Port (common practice) then the sql_connection would not connect. This commit instead changes the Datasource to use the '.' moniker which denotes the local machine. However this instructs the OLE DB provider to use the enabled protocols enabled for the native client instead of only using TCP. This means it will prefer to use the Shared Memory protocol if enabled. Also the Shared Memory protocol is required to be enabled for the SQL Server Agent process on SQL Server 2016.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the module tried to connect to the SQL instance using the name
localhost. This had the side effect of always using the TCP based connection.
If a customer used a non-default Port (common practice) then the sql_connection
would not connect. This commit instead changes the Datasource to use the '.'
moniker which denotes the local machine. However this instructs the OLE DB
provider to use the enabled protocols enabled for the native client instead of
only using TCP. This means it will prefer to use the Shared Memory protocol if
enabled. Also the Shared Memory protocol is required to be enabled for the SQL
Server Agent process on SQL Server 2016.