(MODULES-2543) Purge members from SQL Server Role #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
changed the title
glennsarti
changed the title
|
Looks like the sqlserver::role destroy is not removing membership before dropping the role. |
Previously the purge_members parameter of the sqlserver::role resource was not taking effect. This commit re-instates the acceptance test for this behaviour and changes the sql query used to detect members which are no longer required. It appears the table variable usage was returning zero results for the row count. Instead the detection is changed to just using the SELECT query, instead of an INSERT INTO, which does not require any row count calculation. This commit also modifies the role deletion as SQL Server requires any members to be removed prior to a role being deleted.
glennsarti
changed the title
|
Fixed the role destroy issue. Ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the purge_members parameter of the sqlserver::role resource was not
taking effect. This commit re-instates the acceptance test for this behaviour
and changes the sql query used to detect members which are no longer required.
It appears the table variable usage was returning zero results for the row
count. Instead the detection is changed to just using the SELECT query, instead
of an INSERT INTO, which does not require any row count calculation.