(MODULES-5031) Modify facts for SQL Server 2016 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
changed the title
glennsarti
changed the title
jpogran
reviewed
Jun 5, 2017
| # also WMI: SqlService WHERE SQLServiceType = 4 # MsDtsServer | ||
| 'SQL_DTS_Full' => 'IS', # Integration Services | ||
| 'SQL_DTS_Full' => 'IS', # Integration Services |
There was a problem hiding this comment.
not sure on the question. I was just aligning hashrockets
lib/puppet_x/sqlserver/features.rb
Outdated
| @@ -225,7 +246,7 @@ def self.get_features | |||
| # "RS" | |||
| # ] | |||
| # } | |||
| def self.get_instance_info(version = SQL_2014, instance_name) | |||
| def self.get_instance_info(version = SQL_2016, instance_name) | |||
There was a problem hiding this comment.
Why leave this as a default if it will have to be changed each time we increment?
There was a problem hiding this comment.
just checked the call sites. There's no need for a default. Perhaps just return nil if version is nil
There was a problem hiding this comment.
Changed the code to have no default and just return nil if the version is nil.
Previously the custom facts for the module only supported SQL Server 2012 and 2014. This commit updates the facts to support usage on SQL Server 2016, and adds additional feature detection for features that have been added in Server 2016, or missed out on Server 2014.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the custom facts for the module only supported SQL Server 2012 and
2014. This commit updates the facts to support usage on SQL Server 2016, and
adds additional feature detection for features that have been added in Server
2016, or missed out on Server 2014.