(MODULES-3202) Fix install dependencies with custom source #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the SQL Server module would try to install .Net Framework 3.5 from a custom source, however the source was never exposed on the feature or instance provider and type. This commit: - Adds a new parameter to the feature and instance type called `windows_feature_source` which can be used to set the `/Source` attriute during a call to DISM. See https://support.microsoft.com/en-us/kb/2734782 for more information about installing from a custom source - Modifies the installation logic so that it only calls DISM once if the feature exists. Previously it was called three times. - Documents the new parameter to the README - Adds the missing `source` parameter to the feature type in the README - Only adds the `/Source` parameter to the DISM call, if it is specified in the resource - Modifies the error message to only mentioned the windows_source_location if it was specified in the resource - Removed redundant call to Install-WindowsFeature
| } | ||
| Else | ||
| { | ||
| Write-Host "Failed to install Install .Net Framework 3.5,please make sure the local source is correct." | ||
| Write-Host "Installing .Net Framework 3.5, do not close this prompt..." | ||
| DISM /Online /Enable-Feature /FeatureName:NetFx3 /All /NoRestart /Quiet /LimitAccess #{ "/Source:\"#{source_location}\"" unless source_location.nil? } | Out-Null |
There was a problem hiding this comment.
Depending on the version of Windows (I believe 2008R2 is still supported here), /Alll may fail. Of course this change doesn't change this from what it was, so possibly a new ticket (which may already exist).
|
I'm 👍 for this. Will pull it in tomorrow after the build is green for the other PR that just got merged. In the meantime, any comments from @puppetlabs/windows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the SQL Server module would try to install .Net Framework 3.5 from a
custom source, however the source was never exposed on the feature or instance
provider and type.
This commit:
windows_feature_sourcewhich can be used to set the/Sourceattriuteduring a call to DISM. See https://support.microsoft.com/en-us/kb/2734782 for
more information about installing from a custom source
exists. Previously it was called three times.
sourceparameter to the feature type in the README/Sourceparameter to the DISM call, if it is specified in theresource
was specified in the resource