(maint) Update rakefile for puppetlabs_spec_helper #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rakefile is attempting to override the default puppet lint settings however these settings are more permissive than the defaults and are causing false lint failures e.g. the vendor directory is not excluded in thie Rakefile but the puppetlabs_spec_helper does this by default. This commit removes the ignore_paths setting as the spec helper already does this. Also added a comment that the 80 and 140 char rule changes can be removed once next version of spec_helper is released as they are already the defaults.
glennsarti
changed the title
glennsarti
changed the title
|
I have run this through the adhoc CI pipeline with success |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rakefile is attempting to override the default puppet lint settings however
these settings are more permissive than the defaults and are causing false
lint failures e.g. the vendor directory is not excluded in thie Rakefile but
the puppetlabs_spec_helper does this by default. This PR removes the
ignore_paths setting as the spec helper already does this. Also added a comment
that the 80 and 140 char rule changes can be removed once next version of
spec_helper is released as they are already the defaults.