(FM-5387) Remove simplecov gem and update for modsync #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FM-5387 simplified the windows CI pipeline complexity however an issue was found in ths SQL Server module. The simplecov gem is used to generate code coverage metrics however the results aren't actually used anywhere. Also this gem depends on json with native extensions which is causing CI failures due to lack of devkit. This commit removes the simplecov gem and removes the references in the spec_helper.
The sync.yml file specifies gems in the development and system_tests groups which are merely duplicates of the defaults. This commit changes the gem specification to make yard an optional gem which is appended the required defaults
Module updated with latest modsync and sync.yml settings
glennsarti
changed the title
Puppet-lint 2.0 has a breaking change where the line length test has two names. This commit adds both line length tests to be exempted.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplecov gem is used to generate code coverage metrics however the results
aren't actually used anywhere. Also this gem depends on json with native
extensions which is causing CI failures due to lack of devkit. This PR
removes the simplecov gem and removes the references in the spec_helper.
The sync.yml file specifies gems in the development and system_tests groups
which are merely duplicates of the defaults. This PR changes the gem
specification to make yard an optional gem which is appended the required
defaults