(MODULES-2430) Fix issue parsing facts with puppet 4 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberious
changed the title
- Changed to puppet facts parsing json due to bug with facter which causes facter to hang and test never exits
cyberious
changed the title
| @@ -1,5 +1,6 @@ | |||
| require 'spec_helper_acceptance' | |||
| require 'erb' | |||
| require 'json' | |||
There was a problem hiding this comment.
A require on JSON, but I'm guessing you are allowing the dependency to be transitive based on Puppet? Since I don't see it in the Gemfile.
There was a problem hiding this comment.
Correct but if we don't ensure we require this we won't be able to parse the json result
|
Orher than I think you may want something in the gemfile for this dependency, lgtm |
ferventcoder
added a commit
that referenced
this pull request
Aug 20, 2015
(MODULES-2430) Fix issue parsing facts with puppet 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which causes facter to hang and test never exits