(maint) remove unneeded pre-suite module installs #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ACL, reboot and registry modules are not needed for testing, or as a dependency for this module, so don't install them.
| @@ -53,7 +53,7 @@ | |||
| } | |||
| EOS | |||
| apply_manifest_on(agent, exec_puppet) | |||
| %w(puppetlabs/stdlib puppetlabs/acl cyberious/pget puppetlabs/reboot puppetlabs/registry).each do |dep| | |||
There was a problem hiding this comment.
Check if @zreichert needed the reboot module for his testing
There was a problem hiding this comment.
@cyberious reboot is built into Beaker now!
cyberious
added a commit
that referenced
this pull request
Jun 19, 2015
…-module-dependencies (maint) remove unneeded pre-suite module installs
cyberious
deleted the
maint/master/remove-unnecessary-module-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a dependency for this module, so don't install them.