Skip to content

Commit d344008

Browse files
committed
(MODULES-5030) Remove service_ensure parameter
Previously the service_ensure parameter was defined in the type however it was never implemented in the provider. As such this param had no effect. This commit removes the parameter because: - This parameter is confusing as it is only applicable at installation time, not constantly enforced - Each service can have a different startup type. This is already possible using the install_switches e.g. /BROWSERSVCSTARTUPTYPE=Disabled - Ongoing Windows service state should really be managed by a puppet manifest not by an installation switch
1 parent 4e2b79f commit d344008

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,10 +340,6 @@ Specifies a security mode for SQL Server. Valid options: 'SQL'. If not specified
340340

341341
Default: `undef`.
342342

343-
##### `service_ensure`
344-
345-
Specifies whether the SQL Server service should be running. Valid options: 'automatic' (Puppet starts the service if it's not running), 'manual' (Puppet takes no action), and 'disable' (Puppet stops the service if it's running).
346-
347343
##### `source`
348344

349345
*Required.*

lib/puppet/type/sqlserver_instance.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,6 @@
4444

4545
end
4646

47-
newparam(:service_ensure) do
48-
desc 'Automatic will ensure running if stopped, Manual will set to manual and take no action on current state, :diable will stop and change to service disabled'
49-
newvalues(:automatic, :manual, :disable)
50-
end
51-
5247
newparam(:sql_svc_account, :parent => Puppet::Property::SqlserverLogin) do
5348
desc 'Account for SQL Server service: Domain\User or system account.'
5449
# Default to "NT Service\SQLAGENT$#{instance_name}"

0 commit comments

Comments
 (0)