(FM-2790) Return SQL installations as Facter facts

 - Fact 'sqlserver_instances' contains all detailed instance information
   and is not segregated by SQL version given instance names are unique
   even in a side by side installation
 - Fact 'sqlserver_features' contains all shared features
   segregated by SQL version
 - run_discovery_script method has been completely removed in favor
   of leveraging Facts

 - note that to make the output compatible with Facter, the Ruby symbols
   used in the hashes returned from PuppetX::Sqlserver::Features have
   all been changed to bare strings

Author: Iristyle

lib/facter/sqlserver_features.rb

@@ -0,0 +1,9 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'puppet_x/sqlserver/features'))
+
+Facter.add(:sqlserver_features) do
+  confine :osfamily => :windows
+
+  setcode do
+    PuppetX::Sqlserver::Features.get_features
+  end
+end

lib/facter/sqlserver_instances.rb

@@ -0,0 +1,9 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'puppet_x/sqlserver/features'))
+
+Facter.add(:sqlserver_instances) do
+  confine :osfamily => :windows
+
+  setcode do
+    PuppetX::Sqlserver::Features.get_instances
+  end
+end

lib/puppet/provider/sqlserver.rb

@@ -39,17 +39,6 @@ def not_nil_and_not_empty?(obj)
     !obj.nil? and !obj.empty?
   end
 
-  def self.run_discovery_script
-    features = PuppetX::Sqlserver::Features.get_features
-
-    instances = {
-      # SQL instance names are unique over side-by-side installs
-      :instances => PuppetX::Sqlserver::Features.get_instances.values.inject(:merge),
-      # but features across versions are different
-      :features => !features[SQL_2014].empty? ? features[SQL_2014] : features[SQL_2012]
-    }
-  end
-
   def self.run_install_dot_net
     install_dot_net = <<-DOTNET
 Install-WindowsFeature  NET-Framework-Core

lib/puppet/provider/sqlserver_features/mssql.rb

@@ -8,14 +8,15 @@
 Puppet::Type::type(:sqlserver_features).provide(:mssql, :parent => Puppet::Provider::Sqlserver) do
   def self.instances
     instances = []
-    result = Puppet::Provider::Sqlserver.run_discovery_script
+    result = Facter.value(:sqlserver_features)
     debug "Parsing result #{result}"
-    if !result[:features].empty?
+    result = !result[SQL_2014].empty? ? result[SQL_2014] : result[SQL_2012]
+    if !result.empty?
       existing_instance = {:name => "Generic Features",
                            :ensure => :present,
                            :features =>
                              PuppetX::Sqlserver::ServerHelper.translate_features(
-                               result[:features]).sort!
+                               result).sort!
       }
       debug "Parsed features = #{existing_instance[:features]}"
 

lib/puppet/provider/sqlserver_instance/mssql.rb

@@ -9,14 +9,15 @@
 Puppet::Type::type(:sqlserver_instance).provide(:mssql, :parent => Puppet::Provider::Sqlserver) do
   def self.instances
     instances = []
-    result = Puppet::Provider::Sqlserver.run_discovery_script
+    result = Facter.value(:sqlserver_instances)
     debug "Parsing result #{result}"
-    result[:instances].keys.each do |instance_name|
+    result = result.values.inject(:merge)
+    result.keys.each do |instance_name|
         existing_instance = {:name => instance_name,
                              :ensure => :present,
                              :features =>
                                PuppetX::Sqlserver::ServerHelper.translate_features(
-                                 result[:instances][instance_name][:features]).sort!
+                                 result[instance_name]['features']).sort!
         }
         instance = new(existing_instance)
         instances << instance

lib/puppet_x/sqlserver/features.rb

@@ -1,18 +1,18 @@
-SQL_2012 = 'SQL_2012'
-SQL_2014 = 'SQL_2014'
+SQL_2012 ||= 'SQL_2012'
+SQL_2014 ||= 'SQL_2014'
 
 module PuppetX
   module Sqlserver
     # https://msdn.microsoft.com/en-us/library/ms143786.aspx basic feature docs
     class Features
       private
 
-      SQL_WMI_PATH = {
+      SQL_WMI_PATH ||= {
         SQL_2012 => 'ComputerManagement11',
         SQL_2014 => 'ComputerManagement12',
       }
 
-      SQL_REG_ROOT = 'Software\Microsoft\Microsoft SQL Server'
+      SQL_REG_ROOT ||= 'Software\Microsoft\Microsoft SQL Server'
 
       # http://msdn.microsoft.com/en-us/library/windows/desktop/aa384129(v=vs.85).aspx
       KEY64    ||= 0x100
@@ -102,11 +102,11 @@ def self.get_sql_property_values(version, instance_name, property_name)
 
       def self.get_wmi_instance_info(version, instance_name)
         {
-          :name => instance_name,
-          :version_friendly => version,
-          :version => get_sql_property_values(version, instance_name, 'VERSION').first,
+          'name' => instance_name,
+          'version_friendly' => version,
+          'version' => get_sql_property_values(version, instance_name, 'VERSION').first,
           # typically Software\Microsoft\Microsoft SQL Server\MSSQL11.MSSQLSERVER
-          :reg_root => get_sql_property_values(version, instance_name, 'REGROOT').first,
+          'reg_root' => get_sql_property_values(version, instance_name, 'REGROOT').first,
         }
       end
 
@@ -166,11 +166,11 @@ def self.get_shared_features(version)
       #   "SQL_2012" => {},
       #   "SQL_2014" => {
       #     "MSSQLSERVER" => {
-      #       :name => "MSSQLSERVER",
-      #       :version_friendly => "SQL_2014",
-      #       :version => "12.0.2000.8",
-      #       :reg_root => "Software\\Microsoft\\Microsoft SQL Server\\MSSQL12.MSSQLSERVER",
-      #       :features => [
+      #       "name" => "MSSQLSERVER",
+      #       "version_friendly" => "SQL_2014",
+      #       "version" => "12.0.2000.8",
+      #       "reg_root" => "Software\\Microsoft\\Microsoft SQL Server\\MSSQL12.MSSQLSERVER",
+      #       "features" => [
       #         "SQL Server Replication",
       #         "Database Engine Services",
       #         "Full-Text and Semantic Extractions for Search",
@@ -209,11 +209,11 @@ def self.get_features
       # returns a hash containing instance details
       #
       # {
-      #   :name => "MSSQLSERVER2",
-      #   :version_friendly => "SQL_2014",
-      #   :version => "12.0.2000.8",
-      #   :reg_root => "Software\\Microsoft\\Microsoft SQL Server\\MSSQL12.MSSQLSERVER2",
-      #   :features => [
+      #   "name" => "MSSQLSERVER2",
+      #   "version_friendly" => "SQL_2014",
+      #   "version" => "12.0.2000.8",
+      #   "reg_root" => "Software\\Microsoft\\Microsoft SQL Server\\MSSQL12.MSSQLSERVER2",
+      #   "features" => [
       #     "SQLServer Replication",
       #     "Database Engine Services",
       #     "Full-Text and Semantic Extractions for Search",
@@ -224,8 +224,8 @@ def self.get_features
       # }
       def self.get_instance_info(version = SQL_2014, instance_name)
         sql_instance = get_wmi_instance_info(version, instance_name)
-        feats = get_instance_features(sql_instance[:reg_root], sql_instance[:name])
-        sql_instance.merge({:features => feats})
+        feats = get_instance_features(sql_instance['reg_root'], sql_instance['name'])
+        sql_instance.merge({'features' => feats})
       end
     end
   end