Merge pull request #55 from cyberious/LoginCheckPolicyValidation

Add check for invalid combinination of check_policy and check_expiration

Author: hunner

manifests/login.pp

@@ -63,6 +63,10 @@
 
   validate_re($login_type,['^(SQL_LOGIN|WINDOWS_LOGIN)$'])
 
+  if $check_expiration and !$check_policy {
+    fail ('Can not have check expiration enabled when check_policy is disabled')
+  }
+
   $create_delete = $ensure ? {
     present => 'create',
     absent  => 'delete',

spec/defines/login_spec.rb

@@ -35,4 +35,9 @@
     it_behaves_like 'mssql_tsql command'
     it_behaves_like 'mssql_tsql onlyif'
   end
+  describe 'check_policy' do
+    let(:additional_params) { {:check_policy => false, :check_expiration => true} }
+    let(:raise_error_check) { 'Can not have check expiration enabled when check_policy is disabled' }
+    it_should_behave_like 'validation error'
+  end
 end