(MODULES-1723) Test Ruby Registry methods uncalled

 - Ensure that under Ruby 2.1.x that problematic method calls to
   Win32::Registry are not made.  This was made in a separate commit
   because unfortunately Mocha's any_instance will actually hide other
   errors (which are visible in the prior commit).

   Once code has been changed to alter code paths under other Ruby
   versions, the guarding will be changed accordingly.

Author: Iristyle

spec/unit/puppet/provider/registry_key_spec.rb

@@ -10,6 +10,23 @@
   puppet_key = "SOFTWARE\\Puppet Labs"
   subkey_name ="PuppetRegProviderTest"
 
+  before(:each) do
+    if RUBY_VERSION >= '2.1'
+      # problematic Ruby codepath triggers a conversion of UTF-16LE to
+      # a local codepage which can totally break when that codepage has no
+      # conversion from the given UTF-16LE characters to local codepage
+      # a prime example is that IBM437 has no conversion from a Unicode en-dash
+      Win32::Registry.any_instance.expects(:export_string).never
+
+      Win32::Registry.any_instance.expects(:delete_value).never
+      Win32::Registry.any_instance.expects(:delete_key).never
+
+      # also, expect that we're not using Rubys each_key / each_value which exhibit bad behavior
+      Win32::Registry.any_instance.expects(:each_key).never
+      Win32::Registry.any_instance.expects(:each_value).never
+    end
+  end
+
   describe "#destroy" do
     it "can destroy a randomly created key" do
 

spec/unit/puppet/provider/registry_value_spec.rb

@@ -16,6 +16,23 @@
       PuppetX::Puppetlabs::Registry::KEY_WOW64_64KEY)
   end
 
+  before(:each) do
+    if RUBY_VERSION >= '2.1'
+      # problematic Ruby codepath triggers a conversion of UTF-16LE to
+      # a local codepage which can totally break when that codepage has no
+      # conversion from the given UTF-16LE characters to local codepage
+      # a prime example is that IBM437 has no conversion from a Unicode en-dash
+      Win32::Registry.any_instance.expects(:export_string).never
+
+      Win32::Registry.any_instance.expects(:delete_value).never
+      Win32::Registry.any_instance.expects(:delete_key).never
+
+      # also, expect that we're not using Rubys each_key / each_value which exhibit bad behavior
+      Win32::Registry.any_instance.expects(:each_key).never
+      Win32::Registry.any_instance.expects(:each_value).never
+    end
+  end
+
   after(:all) do
     # Ruby 2.1.5 has bugs with deleting registry keys due to using ANSI
     # character APIs, but passing wide strings to them (facepalm)