(sup-2095) Remove cron_core from dependencies #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, puppetlabs-cron_core was a dependency of this module. Since cron_core is for Puppet 6+ and this module supports 5.5.x, the cron_core module as a dependency is removed in this commit. The cron_core module is provided in core puppet in 5.5.x and in the puppet-agent package for 6.x, so there should not be a requirement to install cron_core.
|
Finished testing this on 5.5.x and 6+. Can confirm I had no issues. That said LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, puppetlabs-cron_core was a dependency of this
module. Since cron_core is for Puppet 6+ and this module supports 5.5.x,
the cron_core module as a dependency is removed in this commit. The
cron_core module is provided in core puppet in 5.5.x and in the
puppet-agent package for 6.x, so there should not be a requirement to
install cron_core.