Restructure if/else logic

Prior to this commit, the checks for managing the databases and having
systemd were done in the same check, so the warning was confusing.  This
commit moves $manage_database_maintenance to its own if clause.  It also
moves the $manage_database_backups inside the version check if, because
it makes more sense to put all of the resources behind the version
check.

Author: m0dular

manifests/init.pp

@@ -31,15 +31,22 @@
   }
 
   if $facts.dig('pe_databases', 'have_systemd') {
-    if $manage_database_maintenance and (versioncmp('2019.0.2', $facts['pe_server_version']) <= 0) {
-      class {'pe_databases::pg_repack':
-        disable_maintenance => $disable_maintenance,
+    if versioncmp('2019.0.2', $facts['pe_server_version']) <= 0 {
+      if $manage_database_maintenance {
+        class {'pe_databases::pg_repack':
+          disable_maintenance => $disable_maintenance,
+        }
+        if $manage_table_settings {
+          # This is to provide for situations, like PE XL,
+          # where the pe-puppetdb database does not exist on the PostgreSQL system being tuned.
+          # In PE XL, the Master and Replica run PostgreSQL for all databases *except* for pe-puppetdb.
+          include pe_databases::postgresql_settings::table_settings
+        }
       }
-      if $manage_table_settings {
-        # This is to provide for situations, like PE XL,
-        # where the pe-puppetdb database does not exist on the PostgreSQL system being tuned.
-        # In PE XL, the Master and Replica run PostgreSQL for all databases *except* for pe-puppetdb.
-        include pe_databases::postgresql_settings::table_settings
+      if defined('$manage_database_backups') {
+        class { 'pe_databases::backup':
+          disable_maintenance => ! $manage_database_backups,
+        }
       }
     }
     else {
@@ -48,11 +55,6 @@
         loglevel => warning,
       }
     }
-    if defined('$manage_database_backups') {
-      class { 'pe_databases::backup':
-        disable_maintenance => ! $manage_database_backups,
-      }
-    }
   }
   else {
     notify { 'pe_databases_systemd_warn':