Fix managing backup class and resources

Prior to this commit, the ensure for the cron entries in the backup
class were hard coded to 'present' and could not be removed once set.
This commit adds a new parameter to manage the cron jobs based on if
$manage_database_backups is set.

Author: m0dular

manifests/backup.pp

@@ -29,6 +29,7 @@
   String  $daily_databases_path     = "${pe_databases::install_dir}/default_daily_databases.txt",
   String  $backup_logging_directory = '/var/log/puppetlabs/pe_databases_backup',
   Integer $retention_policy         = 2,
+  Boolean $disable_maintenance      = true,
 ) {
 
   file { $backup_logging_directory :
@@ -62,6 +63,11 @@
     refreshonly => true,
   }
 
+  $cron_ensure = $disable_maintenance ? {
+    false => 'present',
+    default => 'absent',
+  }
+
   # Since the cron job titles below include the array ('databases') of database names,
   # the crontab for pe-postgres needs to be reset if the array of database names changes,
   # otherwise the change create a new cron job and unmanage the old cron job.
@@ -72,7 +78,7 @@
     $databases_to_backup = $database_backup_set['databases']
     $databases = join($databases_to_backup, ' ')
     cron { "puppet_enterprise_database_backup_${databases_to_backup}":
-      ensure  => present,
+      ensure  => $cron_ensure,
       command => "${backup_script_path} -l ${backup_logging_directory} -t ${backup_directory} -r ${retention_policy} ${databases}",
       user    => 'pe-postgres',
       minute  => $database_backup_set['schedule']['minute'],

manifests/init.pp

@@ -3,7 +3,7 @@
 # @summary Tuning, maintenance, and backups for PE PostgreSQL.
 
 class pe_databases (
-  Boolean $manage_database_backups     = false,
+  Variant[Boolean,Undef] $manage_database_backups     = undef,
   # Manage the inclusion of the pg_repack class
   Boolean $manage_database_maintenance = true,
   # Manage the state of the maintenance tasks, i.e. systemd services and timers
@@ -41,17 +41,18 @@
         # In PE XL, the Master and Replica run PostgreSQL for all databases *except* for pe-puppetdb.
         include pe_databases::postgresql_settings::table_settings
       }
-
-      if $manage_database_backups {
-        include pe_databases::backup
-      }
     }
     else {
       notify { 'pe_databases_version_warn':
         message  => 'This module only supports PE 2019.0.2 and later',
         loglevel => warning,
       }
     }
+    if defined('$manage_database_backups') {
+      class { 'pe_databases::backup':
+        disable_maintenance => ! $manage_database_backups,
+      }
+    }
   }
   else {
     notify { 'pe_databases_systemd_warn':