explicitly do AAAA lookups even if IPv6 is unavailable #1255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolv will only return IPv6 records if there is a local IPv6 address, and this is problematic since the agent may be in a completely different situation than the master - where this code runs.
Resolv will by default only return AAAA records if there are any IPv6 addresses on the host in question. It does this logic itself, it is not based on getaddrinfo or
gai.conf
.Summary
This changes
host_to_ip
so it uses an explicit DNS lookup for the relevant type of DNS record depending on address family.Additional Context
Since this code is run on the master, it may be singlestack (typical for Kubernetes deployment), while the agent consuming the catalog is dualstack. This mismatch causes the agent to get the wrong set of firewall rules.
It should be noted that Resolv will never use anything other than DNS to resolve addresses, so addresses in
/etc/hosts
do not work neither before nor after this patch.Checklist
puppet apply
)